- Description
- In the Linux kernel, the following vulnerability has been resolved: netpoll: fix a use-after-free on shutdown path There is a use-after-free error on netpoll, which is clearly detected by KASAN. BUG: KASAN: slab-use-after-free in _raw_spin_lock_irqsave+0x3b/0x80 Read of size 1 at addr ... by task kworker/9:1 Workqueue: events queue_process Call Trace: skb_dequeue+0x1e/0xb0 queue_process+0x2c/0x600 process_scheduled_works+0x4b6/0x850 worker_thread+0x414/0x5a0 Allocated by task 242: __netpoll_setup+0x201/0x4a0 netpoll_setup+0x249/0x550 enabled_store+0x32f/0x380 Freed by task 0: kfree+0x1b7/0x540 rcu_core+0x3f8/0x7a0 The problem happens when there is a pending TX worker running in parallel with the cleanup path. This is what happens on netpoll shutdown path: 1) __netpoll_cleanup() is called 2) set dev->npinfo to NULL 3) call_rcu() with rcu_cleanup_netpoll_info() 3.1) rcu_cleanup_netpoll_info() tries to cancel all workers with cancel_delayed_work(), but doesn't wait for the worker to finish 4) and kfree(npinfo); Because 3.1) doesn't really cancel the work, as the comment says "we can't call cancel_delayed_work_sync here, as we are in softirq", the TX worker can run after 4). Tl;DR: queue_process() is not an RCU reader, it reaches npinfo through the work item via container_of(). Use disable_delayed_work_sync() to ensure the worker is completely stopped and prevent any future re-arming attempts. Once npinfo is set to NULL, senders will bail out and not queue new work. The disable flag ensures any in-flight re-arming attempts also fail silently. In the future, we can do the cleanup inline here without needing the npinfo->rcu rcu_head, but that is net-next material.
- Source
- 416baaa9-dc9f-4396-8d5f-8c081fb06d67
- NVD status
- Analyzed
- Products
- linux_kernel
CVSS 3.1
- Type
- Primary
- Base score
- 7.8
- Impact score
- 5.9
- Exploitability score
- 1.8
- Vector string
- CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H
- Severity
- HIGH
- nvd@nist.gov
- CWE-416
- Hype score
- Not currently trending
[
{
"nodes": [
{
"cpeMatch": [
{
"criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
"matchCriteriaId": "CAD8F820-D747-4A98-94FA-9C4333E80C3A",
"versionEndExcluding": "6.12.96",
"versionStartIncluding": "3.6.1",
"vulnerable": true
},
{
"criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
"matchCriteriaId": "914AE4BC-3D59-4C5A-9DB5-9CE327B429F7",
"versionEndExcluding": "6.18.39",
"versionStartIncluding": "6.13",
"vulnerable": true
},
{
"criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
"matchCriteriaId": "6228DDD6-4557-4AA3-9F43-AB995D471E42",
"versionEndExcluding": "7.1.4",
"versionStartIncluding": "6.19",
"vulnerable": true
},
{
"criteria": "cpe:2.3:o:linux:linux_kernel:3.6:-:*:*:*:*:*:*",
"matchCriteriaId": "E7D72FF4-3906-4585-B39A-A9B194F53204",
"vulnerable": true
},
{
"criteria": "cpe:2.3:o:linux:linux_kernel:3.6:rc3:*:*:*:*:*:*",
"matchCriteriaId": "E0FCBD80-8462-4642-B2F0-54896776CF07",
"vulnerable": true
},
{
"criteria": "cpe:2.3:o:linux:linux_kernel:3.6:rc4:*:*:*:*:*:*",
"matchCriteriaId": "42F72762-D825-4B81-93BB-5B7F54313F46",
"vulnerable": true
},
{
"criteria": "cpe:2.3:o:linux:linux_kernel:3.6:rc5:*:*:*:*:*:*",
"matchCriteriaId": "41FDE042-F389-4580-BEBB-EBAB4F562477",
"vulnerable": true
},
{
"criteria": "cpe:2.3:o:linux:linux_kernel:3.6:rc6:*:*:*:*:*:*",
"matchCriteriaId": "329C7DD0-9CEA-4D15-B0FE-B3565EE53A63",
"vulnerable": true
},
{
"criteria": "cpe:2.3:o:linux:linux_kernel:3.6:rc7:*:*:*:*:*:*",
"matchCriteriaId": "A6067C5D-29B3-4EE2-BDCA-3F204F25F1C0",
"vulnerable": true
},
{
"criteria": "cpe:2.3:o:linux:linux_kernel:7.2:rc1:*:*:*:*:*:*",
"matchCriteriaId": "5E8B9085-7ADB-4A05-89EF-12949B6A0509",
"vulnerable": true
}
],
"negate": false,
"operator": "OR"
}
]
}
]